+1 from me.
Download is fine, hashes look ok, build is successful on GCC 4.9.4 on
Ubuntu 14.04 and tests pass.
Thanks Marc for your efforts!
On 03/08/2017 07:46 PM, Julian Hyde wrote:
+1 (binding)
Download tar-ball, checked KEYS, checked hashes, ran Rat, checked for
LICENSE, NOTICE, DISCLAIMER.
Rat had several exceptions (listed below) but no show-stoppers.
Thanks for fixing the important issues that I noted in RC5. Next
release please carry on down that list of issues, put some content
into HISTORY.md, and make sure Doxyfle each .patch, .md and .sh file
has a header.
Julian
---
Rat output:
*****************************************************
Summary
-------
Generated at: 2017-03-08T17:39:21-08:00
Notes: 17
Binaries: 20
Archives: 0
Standards: 2890
Apache Licensed: 1251
Generated Documents: 0
JavaDocs are generated, thus a license header is optional.
Generated files do not require license headers.
1601 Unknown Licenses
*****************************************************
Files with unapproved licenses:
./.gitattributes
./.gitignore
./.gitmodules
./BUILDING.md
./CREDITS.md
./DEV_README.md
./Doxyfile
./GENERATOR_FUNCTIONS.md
./HISTORY.md
./README.md
./WORKING_WITH_AN_IDE.md
./build/vagrant/README.md
./parser/preprocessed/SqlLexer_gen.hpp
./parser/preprocessed/genfiles.sh
./query_execution/README.md
./relational_operators/tests/text_scan_faulty_golden_output.txt
./relational_operators/tests/text_scan_faulty_input.txt
./relational_operators/tests/text_scan_golden_output.txt
./relational_operators/tests/text_scan_input.txt
./third_party/README.md
./third_party/patches/benchmark/benchmarkCMake.patch
./third_party/patches/benchmark/benchmarkSrcCMakeLists.patch
./third_party/patches/gflags/CMakeLists.patch
./third_party/patches/gflags/gflags_reporting.cc.patch
./third_party/patches/linenoise/CMakeLists.txt
./third_party/patches/linenoise/linenoise.c.patch
./third_party/patches/linenoise/linenoise.h.patch
./third_party/patches/re2/re2CMake.patch
./third_party/src/cpplint/cpplint.py
(and many more files under third_party/src).
On Wed, Mar 8, 2017 at 2:16 PM, Marc Spehlmann <spehl.apa...@gmail.com> wrote:
This vote is for approval of the Quickstep-0.1.0 RC6.
Voters should download, unpack, build, and test the package before voting.
+1 vote should be accompanied with what you did with the release.
-1 vote should be accompanied with a short reason.
Votes will remain open for 3 days.
___
Changes since RC5:
- Vote email has been refactored. Added a template on the confluence wiki.
- Removed KEYS file from the main github repo. It now exists as a single
source of truth in the SVN repo for release artifacts. I updated the KEYS
file to conform to the apache standard.
- We'll now use sha256, sha512, and md5 to hash the artifacts
- Created History.md file
- Added additional headers based on RAT's output
- Removed references to Pivotal
SHA512
c0cfffb701680ab3a8277f9e1c64f0a91a53e6eb6c32321c67a10aaed65557651d2495ed9503b845d41ab02a1bfb8f4d1481c5bbe270240a4ca702687a87e860
apache-quickstep-incubating-0.1.0.tar.gz
___
The commit to be voted upon:
https://git-wip-us.apache.org/repos/asf?p=incubator-quickstep.git;a=commit;h=f8cf7fba51db3748c1c241c7e8880d499634213b
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/incubator/quickstep/0.1.0/RC6/
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/spehl
Please vote on releasing this package as Apache Incubating Quickstep 0.1.0.
--
Thanks,
Harshad
