Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/218#discussion_r106795847
  
    --- Diff: utility/ExecutionDAGVisualizer.cpp ---
    @@ -176,6 +189,18 @@ void ExecutionDAGVisualizer::bindProfilingStats(
               static_cast<double>(relop_elapsed_time) / (relop_end_time - 
relop_start_time);
           node_info.labels.emplace_back(
               "effective concurrency: " + FormatDigits(concurrency, 2));
    +
    +      DCHECK(workorders_count.find(node_index) != workorders_count.end());
    +      const std::size_t workorders_count_for_node = 
workorders_count.at(node_index);
    +      if (workorders_count_for_node > 0) {
    +        mean_time_per_workorder[node_index] = 
mean_time_per_workorder[node_index]/(1000 * 
static_cast<float>(workorders_count_for_node));
    --- End diff --
    
    This line exceeds 120 characters and there's a lint error message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to