Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/219#discussion_r107299532
  
    --- Diff: query_execution/QueryContext.cpp ---
    @@ -58,7 +59,8 @@ QueryContext::QueryContext(const 
serialization::QueryContext &proto,
                                const CatalogDatabaseLite &database,
                                StorageManager *storage_manager,
                                const tmb::client_id scheduler_client_id,
    -                           tmb::MessageBus *bus) {
    +                           tmb::MessageBus *bus)
    +    : database_(static_cast<const CatalogDatabase&>(database)) {
    --- End diff --
    
    That would give us partial information - we will miss information about 
blocks which get full during the operator execution. Right now, the way we find 
out the memory occupied by a temporary relation is simply by estimating size of 
each block and multiplying that with the number of blocks in the temporary 
relation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to