Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/229#discussion_r110305172
  
    --- Diff: query_optimizer/resolver/Resolver.hpp ---
    @@ -183,6 +184,24 @@ class Resolver {
           const NameResolver *parent_resolver);
     
       /**
    +   * @brief Resolves multiple set operations at the same level.
    +   */
    +  logical::LogicalPtr resolveSetOperations(
    +      const ParseSetOperation &parse_set_operations,
    +      const std::string &set_operation_name,
    +      const std::vector<const Type*> *type_hints,
    +      const NameResolver *parent_resolver);
    +
    +  /**
    +   * @brief Resolves a set operation and returns a logical plan.
    +   */
    +  logical::LogicalPtr resolveSetOperationDispatcher(
    --- End diff --
    
    How about renaming to `resolveSetOperation`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to