Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/230#discussion_r110523933
  
    --- Diff: CMakeLists.txt ---
    @@ -792,3 +794,13 @@ if (ENABLE_DISTRIBUTED)
                             ${GFLAGS_LIB_NAME}
                             ${GRPCPLUSPLUS_LIBRARIES})
     endif(ENABLE_DISTRIBUTED)
    +
    +if(ENABLE_SINGLE_NODE_SERVER)
    +  add_executable (quickstep_client cli/QuickstepClient.cpp)
    +  target_link_libraries(quickstep_client
    +            ${GFLAGS_LIB_NAME}
    +            glog
    +            ${GRPCPLUSPLUS_LIBRARIES}
    +            ${PROTOBUF3_LIBRARIES}
    +            quickstep_cli_SingleNodeServer_proto)
    --- End diff --
    
    All linking libraries should be aligned with `(`, and sort in the alphabet 
order.
    
    ```
                 glog
                 quickstep_cli_SingleNodeServer_proto
                 ${GFLAGS_LIB_NAME}
                 ${GRPCPLUSPLUS_LIBRARIES})
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to