Github user cramja commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/230#discussion_r110542459
  
    --- Diff: cli/CMakeLists.txt ---
    @@ -44,6 +44,20 @@ configure_file (
       "${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
     )
     
    +# Compile the protos for Single Node Server mode.
    +if(ENABLE_SINGLE_NODE_SERVER)
    +  # We will need some of the TMBs libraries
    +  set(CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/third_party/src/tmb/cmake")
    +
    +  find_package(Grpc++ REQUIRED)
    +  include_directories(${GRPCPLUSPLUS_INCLUDE_DIRS})
    --- End diff --
    
    Also not that because of CMAKE scoping, the module will not be added to the 
parent scope's module path:
    
    `/cmakelists.txt`:
    ```
    message("before module path: ${CMAKE_MODULE_PATH}")
    add_subdirectory(cli)
    message("after module path: ${CMAKE_MODULE_PATH}")
    ```
    output:
    ```
    before module path: 
/Users/cramja/workspace/quickstep/incubator-quickstep/cmake
    after module path: 
/Users/cramja/workspace/quickstep/incubator-quickstep/cmake
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to