Github user hakanmemisoglu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/233#discussion_r112069450
  
    --- Diff: utility/tests/DAG_unittest.cpp ---
    @@ -490,6 +490,51 @@ TEST(DAGTest, LinkMetadataBoolTest) {
       EXPECT_FALSE(dag_.getLinkMetadata(1, 0));
     }
     
    +TEST(DAGTest, TopoSortTest) {
    --- End diff --
    
    One way to check the correctness is by first creating `reachable` mapping, 
and then checking for each node `a`, for each node `b` that come after the node 
`a` in `topological_sorted_list`,  there must be no `reachable` path from `b` 
to `a`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to