Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/232#discussion_r112414736
--- Diff: cli/CMakeLists.txt ---
@@ -39,18 +38,39 @@ if (ENABLE_GOOGLE_PROFILER)
set(QUICKSTEP_ENABLE_GOOGLE_PROFILER TRUE)
endif()
+if (ENABLE_NETWORK_CLI)
+ set(QUICKSTEP_ENABLE_NETWORK_CLI TRUE)
+endif()
+
configure_file (
"${CMAKE_CURRENT_SOURCE_DIR}/CliConfig.h.in"
"${CMAKE_CURRENT_BINARY_DIR}/CliConfig.h"
)
+# Compile the protos for Single Node Server mode.
+if(ENABLE_NETWORK_CLI)
--- End diff --
Could we be consistent regarding `if(ENABLE_NETWORK_CLI)` vs `if
(ENABLE_NETWORK_CLI)`?
Same thing below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
