GitHub user jianqiao opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/244

    Fix a problem in CopyGroupList + minor style fixes

    This PR adjusts the implementation of `CopyGroupList::merge_contiguous()` 
to handle some cases correctly.
    
    E.g. let `R`be a split-row-store relation with integer attributes 
`x`,`y`,`z`. It is expected that for query
    ```
    SELECT x, y, z
    FROM R;
    ```
    `merge_contiguous()` merges all attributes into one `ContiguousAttrs` copy 
group, with `bytes_to_copy` set to 12 (size of three integers).
    
    It is also expected that for query
    ```
    SELECT x, y, y
    FROM R;
    ```
    `merge_contiguous()` merges all attributes into two `ContiguousAttrs` copy 
groups, one for `x, y` and one for the last `y`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep fix-copy-group

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #244
    
----
commit 72c7703102f6c367fe346b6bdcde03f1f0036d7b
Author: Jianqiao Zhu <jianq...@cs.wisc.edu>
Date:   2017-05-03T04:55:52Z

    Fix a problem in CopyGroupList + minor style fixes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to