Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136173360
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -82,14 +81,19 @@ static bool ValidateTextScanTextSegmentSize(const char
*flagname,
return true;
}
-static const volatile bool text_scan_text_segment_size_dummy =
gflags::RegisterFlagValidator(
- &FLAGS_textscan_text_segment_size, &ValidateTextScanTextSegmentSize);
+static const volatile bool text_scan_text_segment_size_dummy =
+ gflags::RegisterFlagValidator(
+ &FLAGS_textscan_text_segment_size,
&ValidateTextScanTextSegmentSize);
namespace {
-size_t getFileSize(const string &file_name) {
+static std::size_t GetFileSize(const std::string &file_name) {
--- End diff --
Remove `static`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
