[GitHub] incubator-quickstep pull request #308: Removed unused argument always_mark_f...

[hbdeshmukh]

Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/308#discussion_r143823339
  
    --- Diff: storage/InsertDestinationInterface.hpp ---
    @@ -104,7 +104,7 @@ class InsertDestinationInterface {
        *        insertion from ValueAccessor even when partially full.
        **/
       virtual void bulkInsertTuples(ValueAccessor *accessor,
    -                                bool always_mark_full = false) = 0;
    +                                const bool always_mark_full = false) = 0;
    --- End diff --
    
    Similar to other variants of bulkInsert methods, why are we not getting rid 
of the ``always_mark_full`` parameter in this function? 


---