Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/323#discussion_r150140641
--- Diff: CMakeLists.txt ---
@@ -302,11 +302,11 @@ else()
endif()
endif()
- # OSX 10.12 has deprecated certain system-level APIs which causes
protobuf & glog
+ # OSX 10.12+ has deprecated certain system-level APIs which causes
protobuf & glog
# builds to fail. As a short-term workaround for now, we turn off
deprecated
# warnings so that they do not cause build failures anymore.
# TODO: Remove this workaround by fixing the protobuf_cmake and
glog_cmake.
- if (${CMAKE_SYSTEM} MATCHES "Darwin-16.[0-9]*.[0-9]*")
+ if (${CMAKE_SYSTEM} MATCHES "Darwin-1[6-7]*.[0-9]*.[0-9]*")
--- End diff --
Just curious if you have tried `Darwin-1[67].[0-9]*.[0-9]*`? Thanks!
---
