Github user jianqiao commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/347
  
    LGTM! Merging.
    
    Note that the `concretize` signature in `Physical` plans looks somehow 
cumbersome, we may add a `SubstitutionContext` class to wrap these in a future 
PR.
    ```
    ::quickstep::Predicate* concretize(
        const std::unordered_map<ExprId, const CatalogAttribute*> 
&substitution_map,
        const std::unordered_set<ExprId> &left_expr_ids = 
std::unordered_set<ExprId>(),
        const std::unordered_set<ExprId> &right_expr_ids = 
std::unordered_set<ExprId>()) const override;
    ```


---

Reply via email to