Ah, so this is what made the scribble/reader tests fail -- thanks for
the fix. But there's still a possible problem:
v5.3.4:
-> (raise-read-error "foo" 'src 1 2 3 4)
; src:1:2: foo [,bt for context]
Before this commit:
-> (raise-read-error "foo" 'src 1 2 3 4)
; #<procedure:...ntax/readerr.rkt:33:21>foo [,bt for context]
And now:
-> (raise-read-error "foo" 'src 1 2 3 4)
; src:1:1: foo [,bt for context]
where the column number is different from the first run.
20 minutes ago, ro...@racket-lang.org wrote:
> robby has updated `master' from 54b45607a2 to 1f22800d51.
> http://git.racket-lang.org/plt/54b45607a2..1f22800d51
>
> =====[ One Commit ]=====================================================
> Directory summary:
> 9.8% collects/syntax/
> 90.1% collects/tests/syntax/
>
> ~~~~~~~~~~
>
> 1f22800 Robby Findler <ro...@racket-lang.org> 2013-06-03 08:38
> :
> | fix bug introduced in 6b2a4ff5
> :
> M collects/syntax/readerr.rkt | 1 +
> A collects/tests/syntax/test-readerr.rkt
>
> =====[ Overall Diff ]===================================================
>
> collects/syntax/readerr.rkt
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- OLD/collects/syntax/readerr.rkt
> +++ NEW/collects/syntax/readerr.rkt
> @@ -30,6 +30,7 @@
> (format "~a~a"
> (cond [(not (error-print-source-location)) ""]
> [(srcloc->string (srcloc source-name line col pos span))
> + =>
> (lambda (s)
> (format "~a: " s))]
> [else ""])
>
> collects/tests/syntax/test-readerr.rkt
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> --- /dev/null
> +++ NEW/collects/tests/syntax/test-readerr.rkt
> @@ -0,0 +1,9 @@
> +#lang racket/base
> +(require rackunit syntax/readerr)
> +
> +(check-exn
> + (λ (x)
> + (and (exn:fail:read:eof? x)
> + (regexp-match #rx"^y[01: ]* x" (exn-message x))))
> + (λ () (raise-read-eof-error
> + "x" "y" 1 1 1 1)))
--
((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay:
http://barzilay.org/ Maze is Life!
_________________________
Racket Developers list:
http://lists.racket-lang.org/dev
