I don't think we should take that commit. Is it possible to get a version of the TR tests that either don't run in parallel or run without passing keywords across place channels?
Robby On Wed, Jul 24, 2013 at 9:41 PM, Sam Tobin-Hochstadt <sa...@ccs.neu.edu>wrote: > I will say that I'm not 100% happy with just assuming that TR works in > the absence of a clean test run. Is there a reason not to include > these fixes? > > Sam > > On Wed, Jul 24, 2013 at 5:15 PM, Robby Findler > <ro...@eecs.northwestern.edu> wrote: > > Thanks. > > > > Robby > > > > > > On Wed, Jul 24, 2013 at 3:19 PM, Vincent St-Amour <stamo...@ccs.neu.edu> > > wrote: > >> > >> The problems I've observed were only with the tests. > >> > >> The first problem I reported was caused by a bug/limitation in places, > >> which was fixed by 733907474190da499a1782b230086170c5b87643. It was > >> preventing the TR test suite from running properly. > >> > >> The others were bugs in the TR tests, not in TR itself. > >> > >> TR itself should be fine for the release. > >> > >> Vincent > >> > >> > >> > >> At Wed, 24 Jul 2013 15:03:08 -0500, > >> Robby Findler wrote: > >> > > >> > [1 <text/plain; UTF-8 (7bit)>] > >> > Vincent: can you clarify what the status of TR & the release is, > please? > >> > Are there problems only with tests, or were there problems elsewhere > >> > too? > >> > > >> > Thanks, > >> > Robby > >> > > >> > > >> > On Tue, Jul 23, 2013 at 9:11 AM, Vincent St-Amour > >> > <stamo...@ccs.neu.edu>wrote: > >> > > >> > > The TR tests still fail when using a single place. > >> > > > >> > > The following commits should be included in the release: > >> > > 069ff59a4bd6a988a5670c7e4dd38c1dbbe12ec0 > >> > > 0e7940ab4943600e6f5c8f13ce7ee13e8af9a8f5 > >> > > ab5075bc762356f86bb7dfd34dac8d24ada1a140 > >> > > > >> > > Vincent > >> > > > >> > > > >> > > > >> > > At Mon, 22 Jul 2013 17:49:20 -0400, > >> > > Vincent St-Amour wrote: > >> > > > > >> > > > At Mon, 22 Jul 2013 15:13:28 -0400, > >> > > > Ryan Culpepper wrote: > >> > > > > > >> > > > > Checklist items for the v5.3.6 release > >> > > > > (using the v5.3.5.900 release candidate build) > >> > > > > > >> > > > > Search for your name to find relevant items, reply when you > finish > >> > > > > an > >> > > > > item (please indicate which item/s is/are done). Also, if you > >> > > > > have any > >> > > > > commits that should have been picked, make sure that the changes > >> > > > > are > >> > > in. > >> > > > > > >> > > > > Important: new builds are created without announcement, usually > >> > > whenever > >> > > > > I pick a few commits. If you need to commit changes, please > make > >> > > > > sure > >> > > > > you tell me to pick it into the release branch. > >> > > > > > >> > > > > --> Release candidates are at > >> > > > > --> http://pre.racket-lang.org/release/installers > >> > > > > >> > > > The "Linux/i386/Ubuntu Precise" installer is 64 bits, which is > >> > > > wrong. > >> > > > > >> > > > > * Sam Tobin-Hochstadt <sa...@ccs.neu.edu>, > >> > > > > Vincent St-Amour <stamo...@ccs.neu.edu> > >> > > > > - Match Tests > >> > > > > - Typed Racket Tests > >> > > > > - Typed Racket Updates: update HISTORY > >> > > > > (updates should show v5.3.6 as the most current version; > email > >> > > > > me > >> > > > > to pick the changes when they're done, or tell me if there > are > >> > > > > no > >> > > such > >> > > > > changes.) > >> > > > > >> > > > I get the following error when runing the TR tests: > >> > > > > >> > > > place-channel-put: value not allowed in a message > >> > > > value: '#:methods > >> > > > ... > >> > > > > >> > > > Is 733907474190da499a1782b230086170c5b87643 missing from the > >> > > > release? > >> > > > > >> > > > Now running the tests without places. > >> > > > > >> > > > Vincent > >> > > _________________________ > >> > > Racket Developers list: > >> > > http://lists.racket-lang.org/dev > >> > > > >> > [2 <text/html; UTF-8 (quoted-printable)>] > >> > > > > > > > > > _________________________ > > Racket Developers list: > > http://lists.racket-lang.org/dev > > >
_________________________ Racket Developers list: http://lists.racket-lang.org/dev