----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55797/#review162527 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On Jan. 20, 2017, 11:53 p.m., Mehul Parikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55797/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 11:53 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Madhan Neethiraj, > Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-1311 > https://issues.apache.org/jira/browse/RANGER-1311 > > > Repository: ranger > > > Description > ------- > > Allow non US characters in username, firstname, lastname and groupname fields. > > > Diffs > ----- > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 7ebba8a > security-admin/src/main/java/org/apache/ranger/common/StringUtil.java > a46858d > security-admin/src/main/webapp/scripts/models/VXGroup.js a399de2 > security-admin/src/main/webapp/scripts/models/VXPortalUser.js b031974 > security-admin/src/main/webapp/scripts/modules/XAOverrides.js b23318e > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 3d2612b > security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js c6851c2 > security-admin/src/main/webapp/scripts/utils/XAUtils.js ee401ee > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > b66b801 > security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js > 38ee737 > security-admin/src/main/webapp/scripts/views/users/GroupCreate.js 41678ab > security-admin/src/main/webapp/scripts/views/users/UserCreate.js b0fc105 > security-admin/src/main/webapp/scripts/views/users/UserForm.js adf2f8b > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > 5b6faa7 > security-admin/src/main/webapp/styles/xa.css e2abab9 > > Diff: https://reviews.apache.org/r/55797/diff/ > > > Testing > ------- > > Verified : > > * CRUD operations on service with Non US characters in username field. > * verified display of user having Non-US characters. > * Verified policy creation for the users having non-US characters in username. > * Verified creation and updation of users / groups having non-US characters > in username or groupname. > * Verified login for such users as well. > > > Thanks, > > Mehul Parikh > >
