Not sure what is happening, but I am only able to make internal comments in the 
JIRA.

Paul, thanks for your patch. I reviewed the patch and it looks good. But I 
having challenges applying it. I think it is because it is missing the Author 
tags.
git am --signoff rb56036.patch 
Patch format detection failed.

I generally follow the instructions from this site. 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244

If you don't mind, can see if you create the patch using the following 
statements:
$ git add <modified|add|deleted-files>
$ git commit -m "RANGER-<JIRANUMBER>: <description of the JIRA fix>"
$ git format-patch -n HEAD~

Also, you don't have to upload to the review board, just attach it to the JIRA 
and I can commit it with you as the contributor.

Thanks again and sorry for asking you go through these additional steps.

Bosco

On 1/29/17, 7:38 AM, "Paul Otto (JIRA)" <[email protected]> wrote:

    
        [ 
https://issues.apache.org/jira/browse/RANGER-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15844477#comment-15844477
 ] 
    
    Paul Otto commented on RANGER-1335:
    -----------------------------------
    
    [~bosco], I have updated the review request to reflect the changes 
discussed. It is now as simple as:
    1) changed luceneMatchVersion from 5.0.0 to 5.2.0
    2) removed <requestHandler name="/admin/" class="solr.admin.AdminHandlers" 
/> block and its associated comment
    
    Simple, clean, and works. Thanks!
    
    > Solr for Audit Setup breaks Solr versions 5.5 and above
    > -------------------------------------------------------
    >
    >                 Key: RANGER-1335
    >                 URL: https://issues.apache.org/jira/browse/RANGER-1335
    >             Project: Ranger
    >          Issue Type: Bug
    >          Components: audit
    >            Reporter: Paul Otto
    >            Assignee: Paul Otto
    >
    > Beginning with Solr 5.5, solr.admin.AdminHandlers no longer exists. This 
when the ranger_audit core is added, Solr only partially loads. This can be 
resolved by simply removing the <requestHandler name="/admin/" 
class="solr.admin.AdminHandlers" /> block.
    
    
    
    --
    This message was sent by Atlassian JIRA
    (v6.3.15#6346)
    


Reply via email to