----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56035/#review163614 -----------------------------------------------------------
Ship it! Ship It! ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java (line 698) <https://reviews.apache.org/r/56035/#comment235080> you could pass t as second parameter rather than uing the + to concatenate ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java (line 699) <https://reviews.apache.org/r/56035/#comment235081> It does not seem logical one log record in a cathc block is at error level and one is at info level. If you decide to do that, would recomment that the record that writes too much information sould be at info level and less information should be at error level. The way it is coded here, you write the log that generates too much information at error level and the log that writes one line is enabled at info level. Not opening issue. - dilli dorai On Jan. 30, 2017, 10:19 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56035/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 10:19 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1334 > https://issues.apache.org/jira/browse/RANGER-1334 > > > Repository: ranger > > > Description > ------- > > Fixed few issues found in the recent changes in the usersync code. > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java > 0779918 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java > 0b909d1 > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > 25c0824 > > Diff: https://reviews.apache.org/r/56035/diff/ > > > Testing > ------- > > Confirmed all the unit tests ran successfully. > > > Thanks, > > Sailaja Polavarapu > >
