[jira] [Created] (RANGER-1349) Code block was iterated four times, in fact it should only be executed once during initializing InitD for ranger usersync process

[Qiang Zhang (JIRA)]

Qiang Zhang created RANGER-1349:
-----------------------------------

             Summary: Code block was iterated four times, in fact it should 
only be executed once during initializing InitD for ranger usersync process
                 Key: RANGER-1349
                 URL: https://issues.apache.org/jira/browse/RANGER-1349
             Project: Ranger
          Issue Type: Bug
          Components: kms
            Reporter: Qiang Zhang
            Assignee: Qiang Zhang


There is logical error during initialize InitD for ranger usersync process. The 
following code block will be iterated four times. It's reasonable to execute 
once.
>From following code we can seen that the code block from userSyncScriptName = 
>"ranger-usersync-services.sh" to os.symlink(localScriptName,ubinScriptName) 
>was iterated four times. It only needs be executed one. The error reason is 
>that developer ignores python block syntax.
for rcDir in rcDirList:
if (os.path.isdir(rcDir)):
        for prefix in initPrefixList:
                scriptFn = prefix + initdProgramName
                scriptName = join(rcDir, scriptFn)
                if isfile(scriptName) or os.path.islink(scriptName):
                        os.remove(scriptName)
                os.symlink(initdFn,scriptName)
        userSyncScriptName = "ranger-usersync-services.sh"
        localScriptName = 
os.path.abspath(join(installPropDirName,userSyncScriptName))
        ubinScriptName = join("/usr/bin",initdProgramName)
        if isfile(ubinScriptName) or os.path.islink(ubinScriptName):
        os.remove(ubinScriptName)
        os.symlink(localScriptName,ubinScriptName)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)