----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56303/#review164329 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Feb. 4, 2017, 8:46 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56303/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2017, 8:46 a.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1349 > https://issues.apache.org/jira/browse/RANGER-1349 > > > Repository: ranger > > > Description > ------- > > There is logical error during initialize InitD for ranger usersync process. > The following code block will be iterated four times. It's reasonable to > execute once. > From following code we can seen that the code block from userSyncScriptName = > "ranger-usersync-services.sh" to os.symlink(localScriptName,ubinScriptName) > was iterated four times. It only needs be executed one. The error reason is > that developer ignores python block syntax. > for rcDir in rcDirList: > if (os.path.isdir(rcDir)): > for prefix in initPrefixList: > scriptFn = prefix + initdProgramName > scriptName = join(rcDir, scriptFn) > if isfile(scriptName) or os.path.islink(scriptName): > os.remove(scriptName) > os.symlink(initdFn,scriptName) > userSyncScriptName = "ranger-usersync-services.sh" > localScriptName = > os.path.abspath(join(installPropDirName,userSyncScriptName)) > ubinScriptName = join("/usr/bin",initdProgramName) > if isfile(ubinScriptName) or os.path.islink(ubinScriptName): > os.remove(ubinScriptName) > os.symlink(localScriptName,ubinScriptName) > > > Diffs > ----- > > unixauthservice/scripts/setup.py e20d12e > > Diff: https://reviews.apache.org/r/56303/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
