----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56309/#review164330 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Feb. 4, 2017, 10:37 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56309/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2017, 10:37 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1351 > https://issues.apache.org/jira/browse/RANGER-1351 > > > Repository: ranger > > > Description > ------- > > Fix the declaration of the Loggers to be private final static, or protected > final static (if the child classes would use them). It turned out, that not > all of the loggers are used, so a couple of them can be removed. > > > Diffs > ----- > > agents-audit/src/main/java/org/apache/ranger/audit/dao/DaoManagerBase.java > 3531e05 > > agents-common/src/main/java/org/apache/ranger/admin/client/datatype/RESTResponse.java > d5b4524 > > agents-common/src/main/java/org/apache/ranger/plugin/util/TimedEventUtil.java > b36d581 > > agents-cred/src/main/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProvider.java > bf2abce > > hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseConnectionMgr.java > 3b9f986 > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsConnectionMgr.java > ede8077 > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveConnectionMgr.java > 19badc8 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java 009bcf4 > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAudit.java > 7ff76e5 > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java > aa9d299 > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java > 4d20fe9 > kms/src/main/java/org/apache/ranger/kms/biz/RangerKMSStartUp.java 7035d8b > > knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxConnectionMgr.java > 3907b3a > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > f738601 > > plugin-kms/src/main/java/org/apache/ranger/services/kms/client/KMSResourceMgr.java > bc1d829 > > plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnResourceMgr.java > 23bd9e9 > > ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java > bdff40d > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 8f4619e > security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java e026431 > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 979c6f3 > security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 8f9db09 > security-admin/src/main/java/org/apache/ranger/common/JSONUtil.java 0e8b964 > security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java > a485d38 > security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java > 2a8560d > security-admin/src/main/java/org/apache/ranger/common/RangerConfigUtil.java > dc1aa68 > security-admin/src/main/java/org/apache/ranger/common/StringUtil.java > a190e87 > security-admin/src/main/java/org/apache/ranger/common/TimedEventUtil.java > d67c955 > security-admin/src/main/java/org/apache/ranger/common/TimedExecutor.java > c497393 > > security-admin/src/main/java/org/apache/ranger/common/XMLPropertiesUtil.java > 8fd6196 > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > 6b423bb > > security-admin/src/main/java/org/apache/ranger/common/db/JPABeanCallbacks.java > 6151ec5 > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java > c21469d > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java > 15331ae > security-admin/src/main/java/org/apache/ranger/db/XXAccessAuditDao.java > cb22283 > security-admin/src/main/java/org/apache/ranger/db/XXAssetDao.java 686137e > security-admin/src/main/java/org/apache/ranger/db/XXAuditMapDao.java > 4290d9b > security-admin/src/main/java/org/apache/ranger/db/XXGroupPermissionDao.java > fed83a1 > security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java > c844084 > security-admin/src/main/java/org/apache/ranger/db/XXModuleDefDao.java > dd9ae5f > security-admin/src/main/java/org/apache/ranger/db/XXPermMapDao.java 6c866c3 > security-admin/src/main/java/org/apache/ranger/db/XXResourceDao.java > 8ebcb1b > security-admin/src/main/java/org/apache/ranger/db/XXTrxLogDao.java e2d67f2 > security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java ede0deb > security-admin/src/main/java/org/apache/ranger/db/XXUserPermissionDao.java > 4e18e47 > security-admin/src/main/java/org/apache/ranger/patch/BaseLoader.java > 9feed65 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForHiveServiceDefUpdate_J10006.java > f053212 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForServiceVersionInfo_J10004.java > 380cca0 > > security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java > 54148f1 > > security-admin/src/main/java/org/apache/ranger/patch/PatchPasswordEncryption_J10001.java > 832e963 > > security-admin/src/main/java/org/apache/ranger/patch/PatchPersmissionModel_J10003.java > 5453949 > > security-admin/src/main/java/org/apache/ranger/patch/PatchTagModulePermission_J10005.java > a274f97 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java > b0ec57b > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangeUserNameUtil.java > 531ee34 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java > be40bca > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > 7a15fc3 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/XXTrxLogUpdateUtil.java > beafd1c > security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 52c141b > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java c515085 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > 81d6001 > security-admin/src/main/java/org/apache/ranger/rest/UserREST.java ae917ef > security-admin/src/main/java/org/apache/ranger/rest/XAuditREST.java 5b0991a > security-admin/src/main/java/org/apache/ranger/rest/XKeyREST.java c7a81f9 > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 75ecec9 > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java > 8a08712 > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerDomainObjectSecurityHandler.java > 62bf951 > > security-admin/src/main/java/org/apache/ranger/security/listener/SpringEventListener.java > ba5ebfa > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java > f2f5a62 > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java > 0364b4c > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java > a646d32 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java > 90b34d0 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java > f0b5890 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java > e9401f1 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > 2095567 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java > 3763687 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java > 4e7dba7 > security-admin/src/main/java/org/apache/ranger/service/UserService.java > 826b9e8 > > security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java > af7f30c > security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 8042a37 > security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 632ef60 > security-admin/src/main/java/org/apache/ranger/util/CLIUtil.java 2c6c8a7 > security-admin/src/main/java/org/apache/ranger/util/RangerEnumUtil.java > 9667256 > security-admin/src/main/java/org/apache/ranger/util/RangerRestUtil.java > 2603b51 > > storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormResourceMgr.java > 02f94f9 > ugsync/src/main/java/org/apache/ranger/usergroupsync/AbstractMapper.java > 86b621b > > Diff: https://reviews.apache.org/r/56309/diff/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >
