----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56319/#review164617 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On Feb. 6, 2017, 2:23 p.m., Ankita Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56319/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 2:23 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1352 > https://issues.apache.org/jira/browse/RANGER-1352 > > > Repository: ranger > > > Description > ------- > > Few cases where even if JSON is invalid then also message appears IMPORTED > SUCCSSFULLY : > > case 1: > Json is correct but there is small mistake of case sensitivity instead true > its True. so ideally this json is considered as invalid from jsonlint. > but Ranger import pass in this case, but it does not import any policy. > > Case 2: > if json file is empty , then also it says import successful, ideally it > should failed saying invalid json or something appropriate. > > > Diffs > ----- > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java b0bc2b9 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 89cc32f > security-admin/src/main/webapp/scripts/views/UploadServicePolicy.js a963370 > security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js > 7a1933e > > Diff: https://reviews.apache.org/r/56319/diff/ > > > Testing > ------- > > Checked the message while importing policies in different scenario > > > Thanks, > > Ankita Sinha > >
