> On Feb. 9, 2017, 11:06 a.m., Colm O hEigeartaigh wrote: > > I'm not sure sure if logging on "ERROR" is the right error level here. > > Perhaps DEBUG would be better.
Ok. I agree with your proposal. I rebuilt and update the patch for the issue and request. Please review it. Thanks very much! - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56477/#review164892 ----------------------------------------------------------- On Feb. 9, 2017, 3:39 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56477/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 3:39 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1367 > https://issues.apache.org/jira/browse/RANGER-1367 > > > Repository: ranger > > > Description > ------- > > No log was logged when some errors occurred in classes for the Unix > Authentication Service. > > > Diffs > ----- > > > unixauthservice/src/main/java/org/apache/ranger/authentication/PasswordValidator.java > 8801611 > > unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java > 4b56936 > > Diff: https://reviews.apache.org/r/56477/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
