----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56496/#review165098 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Feb. 9, 2017, 1:24 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56496/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 1:24 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1370 > https://issues.apache.org/jira/browse/RANGER-1370 > > > Repository: ranger > > > Description > ------- > > Fix the createdByUserId to be a private final instance variable, and improve > the PropertiesUtil with a new method to get long values > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java > a0f83c7 > > security-admin/src/main/java/org/apache/ranger/service/XGroupPermissionService.java > 3df5233 > security-admin/src/main/java/org/apache/ranger/service/XGroupService.java > e259eae > > security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java > d1901d9 > > security-admin/src/main/java/org/apache/ranger/service/XModuleDefService.java > b8403e8 > > security-admin/src/main/java/org/apache/ranger/service/XUserPermissionService.java > 3a97ef8 > security-admin/src/main/java/org/apache/ranger/service/XUserService.java > 0d07982 > > security-admin/src/test/java/org/apache/ranger/common/TestPropertiesUtil.java > 7abed8e > > Diff: https://reviews.apache.org/r/56496/diff/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >
