----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56414/#review165105 -----------------------------------------------------------
Ship it! Please add branch information (master and ranger-0.7) - Velmurugan Periasamy On Feb. 7, 2017, 11:53 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56414/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 11:53 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1357 > https://issues.apache.org/jira/browse/RANGER-1357 > > > Repository: ranger > > > Description > ------- > > Atlas entity which is previously associated with one or more tags, and has > such associations mirrored in ranger-admin database, is modified to have no > tags when tagsync is down or unable to process tag events. A full-sync is now > performed using Atlas REST API to synchronize ranger-admin tag objects with > Atlas objects. It is expected that the tags not in Atlas any more, are > removed from ranger-admin database after full-sync, however, those tags and > their associations with entities are still in the ranger-admin database. > > Changed logic to process ALL Atlas entities retrieved by REST call, and > filter out those with no traits at a later stage in the processing, after the > Ranger service-name corresponding to the entity's cluster-name is determined. > > > Diffs > ----- > > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > ec8508e > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java > e0976cd > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java > bf09cfd > > Diff: https://reviews.apache.org/r/56414/diff/ > > > Testing > ------- > > Associated a trait with an Atlas entity; stopped tagsync process; ran full > synchronization using command line with atlasrest as source of tags and > ensured that the entity-tag association as well as entity is removed from the > ranger database. > > > Thanks, > > Abhay Kulkarni > >
