----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56497/#review165121 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Feb. 9, 2017, 1:46 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56497/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 1:46 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1371 > https://issues.apache.org/jira/browse/RANGER-1371 > > > Repository: ranger > > > Description > ------- > > It is not needed to write every generic parameter everywhere, the java > compiler is smart enough - since java 7 - to infer correctly in a lot of > places. Similarly, no need to write initialization for the default values > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/hadoop/security/KrbPasswordSaverLoginModule.java > aa986fd > > agents-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java > e6b3387 > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > bcb07d7 > > agents-common/src/main/java/org/apache/ranger/admin/client/datatype/GrantRevokeData.java > 855758a > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java > e487c85 > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerLegacyConfigBuilder.java > 066c995 > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > 1cb2295 > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java > 839618e > agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java > aa90a92 > > agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java > 00374de > > agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopException.java > 67e6cdf > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAbstractConditionEvaluator.java > fd91c41 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerHiveResourcesAccessedTogetherCondition.java > b18e7cd > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerHiveResourcesNotAccessedTogetherCondition.java > 5036a06 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerIpMatcher.java > b6dbb7e > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java > f91e01e > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptTemplateConditionEvaluator.java > 939107e > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcher.java > e663c46 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractGeolocationProvider.java > c571061 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > 06ccfcc > > agents-common/src/main/java/org/apache/ranger/plugin/geo/BinarySearchTree.java > 8bee24e > > agents-common/src/main/java/org/apache/ranger/plugin/geo/RangerGeolocationData.java > 72e23c7 > > agents-common/src/main/java/org/apache/ranger/plugin/geo/RangerGeolocationDatabase.java > 49cd4e9 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerBaseModelObject.java > 1f6676b > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java > d859368 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 140a59d > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java > c63b54d > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java > 0c1c0ee > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java > ee309bd > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java > d94867a > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagDef.java > 9f2982f > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java > 0c82b7e > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java > f952c57 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java > 79ac674 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java > d3efdc9 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java > 3400d81 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java > 17d1a71 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java > a73f944 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceReadOnly.java > 94c7c9d > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java > 501a7d1 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerDataMaskResult.java > e0854df > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java > 51f2142 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 0ce7a17 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java > 2b2cf9b > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 45bb278 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceAccessInfo.java > 44ec854 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRowFilterResult.java > ad82471 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java > 81dbe0e > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > ffb9523 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java > f691c7c > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerOptimizedPolicyEvaluator.java > b8cb864 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerResourceAccessCacheImpl.java > 598d172 > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java > 18e79e0 > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java > 38260ec > > agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java > 723be3d > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > eda0014 > > agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java > 2c72811 > > agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java > 121dd49 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > b13983f > > agents-common/src/main/java/org/apache/ranger/plugin/store/RangerServiceResourceSignature.java > fca1c1d > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServicePredicateUtil.java > d919697 > > agents-common/src/main/java/org/apache/ranger/plugin/store/file/FileStoreUtil.java > 9d6f395 > > agents-common/src/main/java/org/apache/ranger/plugin/store/file/GeolocationFileStore.java > 98ddd9c > > agents-common/src/main/java/org/apache/ranger/plugin/util/GrantRevokeRequest.java > c9b3481 > > agents-common/src/main/java/org/apache/ranger/plugin/util/KeySearchFilter.java > b9a116e > > agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java > 3fe96ac > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > ffadf79 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java > c2f0b67 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPerfTracer.java > a50a47c > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > b093f5f > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRequestedResources.java > cb3b84a > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > b5c8fb0 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java > ee8a34e > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 73ea6e9 > > agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java > 3940154 > > agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerSimpleMatcher.java > b9c734a > > agents-common/src/test/java/org/apache/ranger/plugin/contextenricher/TestTagEnricher.java > a399fd3 > > agents-common/src/test/java/org/apache/ranger/plugin/errors/TestValidationErrorCode.java > 9336377 > > agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicy.java > cf0daef > > agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicyResourceSignature.java > eae8aa5 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java > caa8e35 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefHelper.java > ae42652 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java > 33e6f4a > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceValidator.java > 40af3ce > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerValidator.java > 5519a2c > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/ValidationTestUtils.java > 5570ce5 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestCacheMap.java > 19362f2 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java > 097e6ff > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > b0d103e > > agents-common/src/test/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluatorTest.java > 769e205 > > agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerDefaultResourceMatcherTest.java > 7532061 > > agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcherTest.java > da81d81 > > agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcher.java > 74cb45d > > agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestResourceMatcher.java > 39bd056 > > Diff: https://reviews.apache.org/r/56497/diff/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >
