-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56888/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1377
https://issues.apache.org/jira/browse/RANGER-1377
Repository: ranger
Description
-------
Use collection.isEmpty method, where possible, and addAll instead a for-each
with add
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java d4ab8d7
security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java e90b106
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 5521ae8
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
15f205a
security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java ec744ea
security-admin/src/main/java/org/apache/ranger/common/MapUtil.java 93fc76b
security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java
77119b1
security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java f4fcfb2
security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java
6864c5a
security-admin/src/main/java/org/apache/ranger/common/StringUtil.java da7231e
security-admin/src/main/java/org/apache/ranger/patch/PatchMigration_J10002.java
d77e4f9
security-admin/src/main/java/org/apache/ranger/patch/PatchPersmissionModel_J10003.java
a48f486
security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java
fb438a7
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 9ec81b3
security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
e84a1aa
security-admin/src/main/java/org/apache/ranger/security/listener/RangerHttpSessionListener.java
e0069b6
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
6eabbb9
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
8d9776a
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
aacf398
security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java
75237de
security-admin/src/main/java/org/apache/ranger/service/UserService.java
164e241
security-admin/src/main/java/org/apache/ranger/service/XPolicyService.java
f3f7c80
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java
817fdda
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java
1c43445
security-admin/src/main/java/org/apache/ranger/service/XUserService.java
0f8156a
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
security-admin/src/main/java/org/apache/ranger/util/RangerEnumUtil.java
6084972
security-admin/src/main/java/org/apache/ranger/util/RangerRestUtil.java
9a2a505
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java
2b773da
Diff: https://reviews.apache.org/r/56888/diff/
Testing
-------
Thanks,
Zsombor Gegesy