----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56827/#review166842 -----------------------------------------------------------
Looks good, but could you create the patch with "git commit" and then "git format-patch -n HEAD~" instead? - Colm O hEigeartaigh On Feb. 19, 2017, 9:41 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56827/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2017, 9:41 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1393 > https://issues.apache.org/jira/browse/RANGER-1393 > > > Repository: ranger > > > Description > ------- > > Changing the class level generic parameter to method level, in this way lot > of class cast can be eliminated > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 15f205a3b5a3bb1ce984647c87c45feeae05ae94 > security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java > fa97bc96ad364fb06df478c1be6bdd8ef7ddb655 > > security-admin/src/main/java/org/apache/ranger/service/RangerAuditFields.java > 7223f109c93a3123e1ae13446dd9f121ae2ca7f7 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java > aacf398663d2d71be0236f83e8e293c9cf9fa72b > > security-admin/src/main/java/org/apache/ranger/service/RangerTagDefServiceBase.java > b85197ccc2073a1570b4a4cd9bdd7ec83420b7ab > > security-admin/src/main/java/org/apache/ranger/service/RangerTagServiceBase.java > 63050998313b2f40d879cbb1681ed908a32cb1cc > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 2b773dac7c7b9c3076d604f61c12ca3fd008877f > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > c54674727ac29b7a8ff70e214370e93b6faf7b27 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyServiceBase.java > 7910cbd8552125ea3ba821ab7433e6a2c2d0803b > > security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefServiceBase.java > b73a629a5429c35dde65575f068fa4947c34dde4 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefServiceBase.java > 803191cccce23753b13277b78fba7051c18fd5eb > > Diff: https://reviews.apache.org/r/56827/diff/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >
