> On 三月 6, 2017, 10:31 a.m., Colm O hEigeartaigh wrote: > > Line +207: SingularAttribute attr = > > entityType.getSingularAttribute(fieldName); > > > > This could be moved into the subsequent if statement, as it's only used in > > there.
OK, thanks. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57272/#review167966 ----------------------------------------------------------- On 三月 7, 2017, 1:02 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57272/ > ----------------------------------------------------------- > > (Updated 三月 7, 2017, 1:02 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1419 > https://issues.apache.org/jira/browse/RANGER-1419 > > > Repository: ranger > > > Description > ------- > > #Solution: > Do some code improvement in Java method XTrxLogService.searchXTrxLogs and > some related code. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java > 20db24e > > > Diff: https://reviews.apache.org/r/57272/diff/2/ > > > Testing > ------- > > #Test Result: > 1.Start Ranger-Admin success > 2.Search success in Audit Admin WebPage > > > Thanks, > > Qiang Zhang > >
