----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57407/#review168439 -----------------------------------------------------------
Did you test the security admin webapp after making the change? - Colm O hEigeartaigh On March 9, 2017, 2:12 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57407/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 2:12 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1430 > https://issues.apache.org/jira/browse/RANGER-1430 > > > Repository: ranger > > > Description > ------- > > the function of '_.omit(object, *keys)' is as follows: > for example: > > _.omit({name: 'moe', age: 50, userid: 'moe1'},'userid'); > will return > => {name: 'moe', age: 50} > > in ranger-admin Web UI, some codes are as follows: > > var attrs = _.omit(this.serverSchema, 'id', 'createDate', 'updateDate', > "version", > "createDate", "updateDate", > "displayOption", > "permList", "forUserId", "status", > "priGrpId", > "updatedBy","isSystem"); > > the keys of 'createDate' and 'updateDate' are duplicated. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/models/RangerPolicy.js f348034 > security-admin/src/main/webapp/scripts/models/RangerPolicyResource.js > 22444d1 > security-admin/src/main/webapp/scripts/models/RangerService.js 9d380db > security-admin/src/main/webapp/scripts/models/RangerServiceDef.js 704f378 > security-admin/src/main/webapp/scripts/models/UserPermission.js 505abe7 > security-admin/src/main/webapp/scripts/models/VXAsset.js 685d7fd > security-admin/src/main/webapp/scripts/models/VXAuditMap.js 92c8704 > security-admin/src/main/webapp/scripts/models/VXGroup.js ca13a6b > security-admin/src/main/webapp/scripts/models/VXModuleDef.js 1a5edc8 > security-admin/src/main/webapp/scripts/models/VXPermMap.js 99cf20d > security-admin/src/main/webapp/scripts/models/VXPortalUser.js 920d205 > > > Diff: https://reviews.apache.org/r/57407/diff/1/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
