----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57488/#review168584 -----------------------------------------------------------
Fix it, then Ship it! ugsync/src/test/resources/groupFile Lines 1 (patched) <https://reviews.apache.org/r/57488/#comment240840> Include this file in rat exclude list. Otherwise build will fail with unapproved license. ugsync/src/test/resources/passwordFile Lines 1 (patched) <https://reviews.apache.org/r/57488/#comment240841> Include this file in rat exclude list. Otherwise build will fail with unapproved license. - Velmurugan Periasamy On March 10, 2017, 1:28 a.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57488/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 1:28 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1435 > https://issues.apache.org/jira/browse/RANGER-1435 > > > Repository: ranger > > > Description > ------- > > Made code changes to read both password file and group file from the usersync > configuration file instead of using hardcoded values. Also added/modified > corresponding unit tests. > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > 2c9365d > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java > f5a4c9a > > ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java > 831e92d > ugsync/src/test/resources/groupFile PRE-CREATION > ugsync/src/test/resources/passwordFile PRE-CREATION > > > Diff: https://reviews.apache.org/r/57488/diff/1/ > > > Testing > ------- > > 1. Successfully ran unit tests. > 2. Also verified new & existing functionality of unix sync on cluster with > replacing the unixusersync jar file containing the changes. > > > Thanks, > > Sailaja Polavarapu > >
