----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56879/#review168700 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On 二月 21, 2017, 12:07 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56879/ > ----------------------------------------------------------- > > (Updated 二月 21, 2017, 12:07 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1402 > https://issues.apache.org/jira/browse/RANGER-1402 > > > Repository: ranger > > > Description > ------- > > There is a NPE if there is a problem with the HiveClient driverClassName. > This is because the code is trying to put a "null" HiveClient instance into a > ConcurrentMap. > > > Diffs > ----- > > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveConnectionMgr.java > b36d5da > > > Diff: https://reviews.apache.org/r/56879/diff/1/ > > > Testing > ------- > > Tested that no NPE appears in the logs after the fix. > > > Thanks, > > Colm O hEigeartaigh > >
