-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57303/
-----------------------------------------------------------
(Updated March 11, 2017, 8:44 a.m.)
Review request for ranger, Madhan Neethiraj and Ramesh Mani.
Changes
-------
Addressed review comments
Bugs: RANGER-1321
https://issues.apache.org/jira/browse/RANGER-1321
Repository: ranger
Description
-------
Default policy creation is best handled by the Service-specific class. The
relevant code is moved out ServiceDBStore and into the RangerServiceBase class.
It is expected that subclasses of RangerServiceBase representing each Service,
will specialize the default policy creation behavior if necessary by overriding
createDefaultPolicies() API.
RangerServiceKafka needs special handling if the cluster is Kerberized.
Currently, there is only a placeholder for it.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java
debaa83
agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java
bcf9064
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
324551d
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/RangerServiceHdfs.java
bc12da9
plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java
d2b60bd
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/RangerServiceKafka.java
86e97bc
plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java
7657099
plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java
470c711
plugin-yarn/src/main/java/org/apache/ranger/services/yarn/RangerServiceYarn.java
69f2bc3
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
053df24
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java
531674a
Diff: https://reviews.apache.org/r/57303/diff/4/
Changes: https://reviews.apache.org/r/57303/diff/3-4/
Testing
-------
Very basic testing done only in a simple cluster.
Thanks,
Abhay Kulkarni
