> On March 14, 2017, 12:56 p.m., Colm O hEigeartaigh wrote:
> > Looks good in general, however I think it would be a good idea to preserve
> > the "if [ ! $? = "0" ];then" statement, but move it after "mkdir -p
> > ${RANGER_PID_DIR_PATH}" on line 1369.
>
> pengjianhua wrote:
> Ok. Thanks.
I modified the patch according to your review and updated it. Thanks.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57584/#review168893
-----------------------------------------------------------
On March 14, 2017, 3:37 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57584/
> -----------------------------------------------------------
>
> (Updated March 14, 2017, 3:37 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1449
> https://issues.apache.org/jira/browse/RANGER-1449
>
>
> Repository: ranger
>
>
> Description
> -------
>
> 1. There is RANGER_PID_DIR_PATH parameter in install.properties. But There is
> hard code at the begin of setup.sh
> pidFolderName='/var/run/ranger'
> mkdir -p $
> {pidFolderName}
>
> if [ ! $? = "0" ];then
> log "Make $pidFolderName failure....!!";
> exit 1;
> fi
> 2. The ranger-admin-services.sh will set default value and create default
> path when the RANGER_PID_DIR_PATH parameter is empty. The setup.sh doesn't
> set default value and create default path.
>
>
> Diffs
> -----
>
> security-admin/scripts/setup.sh 87be127
>
>
> Diff: https://reviews.apache.org/r/57584/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
