-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57725/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1465
    https://issues.apache.org/jira/browse/RANGER-1465


Repository: ranger


Description
-------

Comment lines have not been filtered out when the populate_global_dict function 
parsed install.properties in installing scripts. So if we use '#' to comment a 
line and it includes '=', the comment will not work. On the left of the '=', it 
will be parsed as a key and the right will be parsed as a value. As a result, 
there are two problems as follows:
1. There are invalid attribute values in globalDict variable.
2. Invalid parsing will degrade the performance of program.


Diffs
-----

  kms/scripts/db_setup.py d8b4b63 
  kms/scripts/dba_script.py 1e264cc 


Diff: https://reviews.apache.org/r/57725/diff/1/


Testing
-------


Thanks,

pengjianhua

Reply via email to