----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57827/#review169689 -----------------------------------------------------------
Looks fine, but change the comment from "create group if not exists" to "create group if it does not exist". - Colm O hEigeartaigh On March 22, 2017, 3:51 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57827/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 3:51 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1469 > https://issues.apache.org/jira/browse/RANGER-1469 > > > Repository: ranger > > > Description > ------- > > The user group would be duplicate created if the user group existed during > installing Ranger Policy Admin. > > > Diffs > ----- > > security-admin/scripts/setup.sh bc94874 > > > Diff: https://reviews.apache.org/r/57827/diff/1/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
