----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56887/#review170419 -----------------------------------------------------------
Please resubmit a working patch. I suggest leaving the String.valueOf changes out of this patch, and just focus on changing the order of the string comparisons. - Colm O hEigeartaigh On Feb. 21, 2017, 3:25 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56887/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 3:25 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1377 > https://issues.apache.org/jira/browse/RANGER-1377 > > > Repository: ranger > > > Description > ------- > > Fix code to use "xxx".equals(yyy) instead of yyy.equals("xxx") > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java d4ab8d7 > security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java e90b106 > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 5521ae8 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 15f205a > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java f512049 > security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java ec744ea > security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 3542da2 > security-admin/src/main/java/org/apache/ranger/common/AppConstants.java > 7fa2292 > security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java > 22d4b89 > security-admin/src/main/java/org/apache/ranger/common/RESTErrorUtil.java > 967804a > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 4fb52a4 > security-admin/src/main/java/org/apache/ranger/common/SearchGroup.java > 77119b1 > security-admin/src/main/java/org/apache/ranger/common/SearchUtil.java > f4fcfb2 > security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java > 6864c5a > security-admin/src/main/java/org/apache/ranger/common/StringUtil.java > da7231e > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java > e3b878b > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java > d718441 > > security-admin/src/main/java/org/apache/ranger/entity/XXAccessAuditBase.java > 8efcfc3 > security-admin/src/main/java/org/apache/ranger/entity/XXAsset.java 158c966 > security-admin/src/main/java/org/apache/ranger/entity/XXAuditMap.java > 95c2bf6 > security-admin/src/main/java/org/apache/ranger/entity/XXAuthSession.java > deedc87 > security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 04aedbd > security-admin/src/main/java/org/apache/ranger/entity/XXPermMap.java > 7c6b96c > security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java > f7df09e > security-admin/src/main/java/org/apache/ranger/entity/XXPortalUserRole.java > 97f52c4 > security-admin/src/main/java/org/apache/ranger/entity/XXResource.java > e571a4f > security-admin/src/main/java/org/apache/ranger/entity/XXTrxLog.java ceea47b > security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 512c567 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java > 1ddd367 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > fb438a7 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 9ec81b3 > > security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java > 3fdd5c2 > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java > 8d9363a > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java > 948d328 > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java > e7e5f5d > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java > c8d22aa > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKrbFilter.java > dbf6248 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > 7d8fdb2 > > security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java > 9a4aa3b > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java > 8d9776a > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java > 004524b > security-admin/src/main/java/org/apache/ranger/service/XAssetService.java > 81c720d > > security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java > 1dfe19f > security-admin/src/main/java/org/apache/ranger/service/XGroupService.java > c478dbc > > security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java > 0d735da > security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java > bc335cc > > security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java > bb12e3e > > security-admin/src/main/java/org/apache/ranger/service/XResourceService.java > 817fdda > security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java > 1c43445 > security-admin/src/main/java/org/apache/ranger/service/XUserService.java > 0f8156a > > security-admin/src/main/java/org/apache/ranger/service/filter/RangerRESTAPIFilter.java > 5b78925 > security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java 3f7935e > security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e > security-admin/src/main/java/org/apache/ranger/util/RestUtil.java b50d161 > > > Diff: https://reviews.apache.org/r/56887/diff/1/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >
