> On March 29, 2017, 4:25 p.m., Colm O hEigeartaigh wrote: > > Ship It!
BTW please update the JIRA issue to RANGER-1427 (not RANGER-1428) - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57372/#review170422 ----------------------------------------------------------- On March 7, 2017, 12:04 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57372/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 12:04 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1428 > https://issues.apache.org/jira/browse/RANGER-1428 > > > Repository: ranger > > > Description > ------- > > Calling Boolean.getBoolean is usually a sign of wrong code. In this case, it > was the sign of a dead code, which is not called anymore. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/service/XResourceService.java > b7cbc59 > > > Diff: https://reviews.apache.org/r/57372/diff/1/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >
