-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57285/#review171420
-----------------------------------------------------------



These are some errors. Please fix it.

.git/rebase-apply/patch:38: trailing whitespace.
 * 
.git/rebase-apply/patch:41: trailing whitespace.
 * c) The tag "HbaseColTag" is associated with "write" permission to the "dev" 
group to the "col1" column of the "colfam1" column family of 
.git/rebase-apply/patch:43: trailing whitespace.
 * 
.git/rebase-apply/patch:55: trailing whitespace.
    
.git/rebase-apply/patch:63: trailing whitespace.
    
warning: squelched 74 whitespace errors
warning: 79 lines add whitespace errors.

- Qiang Zhang


On 三月 3, 2017, 12:21 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57285/
> -----------------------------------------------------------
> 
> (Updated 三月 3, 2017, 12:21 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1421
>     https://issues.apache.org/jira/browse/RANGER-1421
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> We currently have some resource based unit tests for Kafka, HDFS, etc but no 
> tag-based tests. This task is to add tag-based authorization tests to the 
> existing test-suites.
> 
> 
> Diffs
> -----
> 
>   
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java
>  7aec352 
>   
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/RangerAdminClientImpl.java
>  e5c4113 
>   hbase-agent/src/test/resources/hbase-policies-tag.json PRE-CREATION 
>   hbase-agent/src/test/resources/hbase-policies.json f113076 
>   hbase-agent/src/test/resources/ranger-hbase-security.xml b71f18c 
>   
> hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/HDFSRangerTest.java 
> f5e8cb7 
>   
> hdfs-agent/src/test/java/org/apache/ranger/services/hdfs/RangerAdminClientImpl.java
>  99d3f78 
>   hdfs-agent/src/test/resources/hdfs-policies-tag.json PRE-CREATION 
>   hdfs-agent/src/test/resources/hdfs-policies.json 4565b8b 
>   hdfs-agent/src/test/resources/ranger-hdfs-security.xml 3062108 
>   
> hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java
>  35f7f0b 
>   
> hive-agent/src/test/java/org/apache/ranger/services/hive/RangerAdminClientImpl.java
>  8b48dd8 
>   hive-agent/src/test/resources/hive-policies-tag.json PRE-CREATION 
>   hive-agent/src/test/resources/hive-policies.json dd71424 
>   hive-agent/src/test/resources/ranger-hive-security.xml 46fd28e 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java
>  cef9f12 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
>  898c785 
>   
> plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/RangerAdminClientImpl.java
>  26dc151 
>   plugin-kafka/src/test/resources/kafka-policies-tag.json PRE-CREATION 
>   plugin-kafka/src/test/resources/kafka-policies.json cc1c927 
>   plugin-kafka/src/test/resources/ranger-kafka-security.xml b2cc5f8 
> 
> 
> Diff: https://reviews.apache.org/r/57285/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>

Reply via email to