> On 四月 13, 2017, 11:55 a.m., Colm O hEigeartaigh wrote: > > What is the difference if any between "os.path.join" and simply "join" here?
from os.path import isfile, join, dirname, basename In above clause we can see that the corresponding module has been imported. So the os.path can be ingored. In the program some clauses use the os.path, while others do not use the os.path. We should also be consistent in these clauses. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58414/#review171858 ----------------------------------------------------------- On 四月 13, 2017, 9:39 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58414/ > ----------------------------------------------------------- > > (Updated 四月 13, 2017, 9:39 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1511 > https://issues.apache.org/jira/browse/RANGER-1511 > > > Repository: ranger > > > Description > ------- > > Different global variable saved the same configuration file path in > unixauthservice. The code logic is inconsistent. > > > Diffs > ----- > > unixauthservice/scripts/setup.py c7aa959 > > > Diff: https://reviews.apache.org/r/58414/diff/1/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
