> On 四月 13, 2017, 5:50 a.m., Gautam Borad wrote: > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java > > Lines 154 (patched) > > <https://reviews.apache.org/r/58332/diff/1/?file=1687769#file1687769line155> > > > > Ideally, we should fallback to default (en_US) locale, in case the file > > is not found.
Hi Thank you for your advice. I used Locale.getDefault() to get the current system environment language. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58332/#review171843 ----------------------------------------------------------- On 四月 11, 2017, 7:34 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58332/ > ----------------------------------------------------------- > > (Updated 四月 11, 2017, 7:34 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1508 > https://issues.apache.org/jira/browse/RANGER-1508 > > > Repository: ranger > > > Description > ------- > > Use the browser to log in Ranger admin in Chinese operation system. The > browser returns garbled when an error occurs. The error reason is that the > Ranger admin used hard code to compare error information between Chinese > character and English character. So we need support the internationalization > function to solve this problem. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java > 580b6bc > security-admin/src/main/resources/internationalization/messages.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_cs_CZ.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_de.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_es_ES.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_fr.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_it.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_ko_KR.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_lt.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_pl.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_pt_BR.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_pt_PT.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_uk_UA.properties > PRE-CREATION > > security-admin/src/main/resources/internationalization/messages_zh_CN.properties > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58332/diff/1/ > > > Testing > ------- > > tested it > > > Thanks, > > pengjianhua > >
