> On April 18, 2017, 9:26 a.m., Colm O hEigeartaigh wrote: > > The diff is just the pom diff...it looks like the rest of the patch is > > missing? > > Ankita Sinha wrote: > The patch is complete, it just contains the changes related to pom. The > existing code needs those jar at runtime. > > Colm O hEigeartaigh wrote: > Did you mean to submit the rest of the patch in > https://reviews.apache.org/r/58494/ ? That just contains the pom changes as > well. > > Ankita Sinha wrote: > Committed to Master branch : > https://github.com/apache/ranger/commit/6cfb01883fb97bd98e5e5b7baacb3cdd85a15b68 > Committed to 0.7 branch : > https://github.com/apache/ranger/commit/6c0b06252ad670bdbd5ffba93a3b51015308e9ec > > So the current patch is on top of the above commits to work with > different setting of HiveMetastore. So in some cases the Jar was missing and > this and https://reviews.apache.org/r/58494/ patch handles that for > ranger-0.7 and master branch respectively.
OK got it, thanks for the explanation! - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58495/#review172181 ----------------------------------------------------------- On April 18, 2017, 6:24 a.m., Ankita Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58495/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 6:24 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1483 > https://issues.apache.org/jira/browse/RANGER-1483 > > > Repository: ranger > > > Description > ------- > > Added some libraries for Ranger to use Hive Metastore for Test connection and > Resource Lookup > > > Diffs > ----- > > pom.xml de2eeb2 > security-admin/pom.xml fd387a8 > > > Diff: https://reviews.apache.org/r/58495/diff/1/ > > > Testing > ------- > > Tested Hive Test Connection and Resource Lookup with different settings on > simple and secure cluster. > > > Thanks, > > Ankita Sinha > >
