> On April 21, 2017, 8:35 a.m., Colm O hEigeartaigh wrote: > > In db_setup.py, it appears that RANGER_ADMIN_CONF is only used for the "if > > is_unix" block. It should work for windows as well. Same goes for > > dba_script.py. There is also some trailing whitespace after the > > "RANGER_ADMIN_CONF" definition in both python files that could be fixed.
Ok. I fixed it according to your review and rebuit the patch. Thanks. - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58529/#review172613 ----------------------------------------------------------- On April 22, 2017, 3:42 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58529/ > ----------------------------------------------------------- > > (Updated April 22, 2017, 3:42 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1525 > https://issues.apache.org/jira/browse/RANGER-1525 > > > Repository: ranger > > > Description > ------- > > Some users hope that the execute programs and install configuration file of > the Ranger Admin can be deployed separately when they integrate Ranger into > the big data platform or business systems to install Ranger through the > platform or systems. We should support the need in the case of compatibility > with existing logic. > > Solution: > 1. Users can set RANGER_ADMIN_CONF environment variable to meet their needs. > 2. The program read configuration information from the RANGER_ADMIN_CONF path. > 3. Users can re-plan programs and configurations when installing the Ranger > Admin. Then they set RANGER_ADMIN_CONF value as configuration path. > > > Diffs > ----- > > security-admin/scripts/db_setup.py 6e79151 > security-admin/scripts/dba_script.py 83d6fe7 > security-admin/scripts/setup.sh e77b2a9 > > > Diff: https://reviews.apache.org/r/58529/diff/2/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
