-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58219/#review173179
-----------------------------------------------------------
There are several instances where you are creating an Iterator which is just
debug logging, meaning that if debug logging is turned off we are doing a load
of empty iterations, e.g.:
+ for (RangerServiceDef.RangerDataMaskTypeDef maskTypeDef
: maskTypesToAdd) {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("maskTypeDef-to-add:[" +
maskTypeDef + "]");
+ }
+ }
+
Much better to instead put the if statement outside the for loop.
- Colm O hEigeartaigh
On April 21, 2017, 9:23 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58219/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:23 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Nitin Galave.
>
>
> Bugs: RANGER-1494
> https://issues.apache.org/jira/browse/RANGER-1494
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Supported modification of tag servicedef to reflect changes to non-tag based
> service definition.
>
>
> Diffs
> -----
>
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java
> 7b3bd95
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
> 0793a6a
>
> agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java
> 1702dec
>
>
> Diff: https://reviews.apache.org/r/58219/diff/2/
>
>
> Testing
> -------
>
> Created/Deleted/Updated non-tag service-def with dataMaskDef modifications.
> Ensured they are correctly reflected in the tag service-def.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
