----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57868/#review174616 -----------------------------------------------------------
I agree with point (1). However, for point (2) I feel that "Module Details" is fine, as the page lists the module name + then user/group permissions. Could you resubmit a patch with just the first change? - Colm O hEigeartaigh On March 23, 2017, 8:32 a.m., Haihui Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57868/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 8:32 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > 1.Navigate to Ranger Web UI's Settings Permissions tab, the permissions table > header is Permissions,Groups,Users,Action. But the first column in the table > is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the > table header should be Modules,Groups,Users,Action. > 2.Web UI's Settings Permissions tab, click action to edit permission, and the > page display bellow 'Edit Permission' is 'Policy Details' (0.6.3 version), > 'Module Details'(0.7.0 version ,1.0.0 version). The action is 'edit > permission',so 'Permission Details' or 'Module Permission Details' may be > more reasonable. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 7a4b82c > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js > 92c07c7 > > security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html > 909d2fc > > > Diff: https://reviews.apache.org/r/57868/diff/1/ > > > Testing > ------- > > Page Display, test ok. > > > File Attachments > ---------------- > > RANGER-1411-0.6.3.patch > > https://reviews.apache.org/media/uploaded/files/2017/03/23/6b59ee99-c8bb-4458-badb-faf8b7e87f66__RANGER-1411-0.6.3.patch > RANGER-1411-0.7.0.patch > > https://reviews.apache.org/media/uploaded/files/2017/03/23/9af2e730-7030-42c9-8e61-8d3fbb0f53a9__RANGER-1411-0.7.0.patch > > > Thanks, > > Haihui Xu > >
