----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59221/#review174773 -----------------------------------------------------------
Why not remove it from the install scripts as well? e.g. grep -rl "XAAUDIT.DB.PASSWORD" * agents-common/scripts/enable-agent.sh hbase-agent/scripts/install.sh hdfs-agent/scripts/install.sh hive-agent/scripts/install.sh knox-agent/scripts/install.sh plugin-kms/scripts/enable-kms-plugin.sh storm-agent/scripts/install.sh - Colm O hEigeartaigh On May 12, 2017, 2:51 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59221/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 2:51 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1574 > https://issues.apache.org/jira/browse/RANGER-1574 > > > Repository: ranger > > > Description > ------- > > The XAAUDIT.DB.PASSWORD property had been deleted in RANGER-900. The > following redundant code should be deleted for plugin installer because these > codes will never be executed. > auditCredAlias="auditDBCred" > auditdbCred=$(getInstallProperty 'XAAUDIT.DB.PASSWORD') > if [ "${auditdbCred}" != "" ]; then > create_jceks "${auditCredAlias}" "${auditdbCred}" "${CredFile}" > > I had checked the property for plugin-yarn, > plugin-solr,plugin-kafka,plugin-atlas,hive-agent,hdfs-agent and hbase-agent. > The test result shows that the modification is ok. > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh d13875c > > > Diff: https://reviews.apache.org/r/59221/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
