----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59327/#review175230 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On May 17, 2017, 1:50 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59327/ > ----------------------------------------------------------- > > (Updated May 17, 2017, 1:50 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1585 > https://issues.apache.org/jira/browse/RANGER-1585 > > > Repository: ranger > > > Description > ------- > > Some error logs in RangerBasePlugin.java! > for example: > public void grantAccess(GrantRevokeRequest request, > RangerAccessResultProcessor resultProcessor) throws Exception { > if(LOG.isDebugEnabled()) { > LOG.debug("==> RangerAdminRESTClient.grantAccess(" + request + > ")"); > } > ... > if(LOG.isDebugEnabled()) { > LOG.debug("<== RangerAdminRESTClient.grantAccess(" + request + > ")"); > } > } > we should change 'LOG.debug("==> RangerAdminRESTClient.grantAccess(" + > request + ")");' to 'LOG.debug("==> RangerBasePlugin.grantAccess(" + request > + ")");' > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 13900c6 > > > Diff: https://reviews.apache.org/r/59327/diff/1/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
