----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59388/#review175478 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On May 19, 2017, 7:26 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59388/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 7:26 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1590 > https://issues.apache.org/jira/browse/RANGER-1590 > > > Repository: ranger > > > Description > ------- > > modify code for the error logs in > ranger\knox-agent\src\main\java\org\apache\ranger\services\knox\client\KnoxClient.java > chang from LOG.debug("Knox service look up response JSON string: " + > jsonString); to LOG.debug("Knox service lookup response JSON string: " + > jsonString); > Reason :keep the log consistent: > response = webResource.accept(EXPECTED_MIME_TYPE) > .get(ClientResponse.class); > LOG.debug("Knox service lookup response: " + response); > if (response != null) { > if (response.getStatus() == 200) { > String jsonString = response.getEntity(String.class); > LOG.debug("Knox service lookup response JSON string: " + jsonString); > > > Diffs > ----- > > > knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java > ec08ae8 > > > Diff: https://reviews.apache.org/r/59388/diff/1/ > > > Testing > ------- > > tested it > > > Thanks, > > pengjianhua > >
