> On 五月 25, 2017, 9:01 a.m., Colm O hEigeartaigh wrote: > > Looks good, but we'll then have three implementations of the > > getInstallProperty function in different scripts. Would it be possible to > > put the common functions into a separate script that gets picked up by the > > other scripts?
Hi Colm O hEigeartaigh, I found the different scripts which have the same getInstallProperty function are in different projects like ranger-admin or ranger-usersync. And ranger-admin or ranger-usersync can install in different host. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59571/#review176046 ----------------------------------------------------------- On 五月 25, 2017, 8:15 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59571/ > ----------------------------------------------------------- > > (Updated 五月 25, 2017, 8:15 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1613 > https://issues.apache.org/jira/browse/RANGER-1613 > > > Repository: ranger > > > Description > ------- > > 1.In install.properties, I configure 'ranger_base_dir=/etc/ranger/xiehh' > 2.I execute ranger-usersync-services.sh to start > [root@zdh41 ranger-1.0.0-SNAPSHOT-usersync]# ./ranger-usersync-services.sh > start > Starting Apache Ranger Usersync Service > Apache Ranger Usersync Service with pid 23417 has started. > 3.[root@zdh41 ranger-1.0.0-SNAPSHOT-usersync]# ps -ef|grep 23417 > root 23417 1 31 15:39 pts/1 00:00:03 java -Dproc_rangerusersync > -Dlog4j.configuration=file:/etc/ranger/usersync/conf/log4j.properties > -Duser=root -Dhostname=zdh41 -Dlogdir=logs -cp > /home/rangerusersync/ranger-1.0.0-SNAPSHOT-usersync/dist/*:/home/rangerusersync/ranger-1.0.0-SNAPSHOT-usersync/lib/*:/home/rangerusersync/ranger-1.0.0-SNAPSHOT-usersync/conf:/etc/hadoop/conf/* > org.apache.ranger.authentication.UnixAuthenticationService -enableUnixAuth > > The Configuration > '-Dlog4j.configuration=file:/etc/ranger/usersync/conf/log4j.properties' will > not find the file log4j.properties,because the dir > '/etc/ranger/usersync/conf' is not right ,it should be > '/etc/ranger/xiehh/usersync/conf' > > > So we should change 'nohup java -Dproc_rangerusersync > -Dlog4j.configuration=file:/etc/ranger/usersync/conf/log4j.properties > ${JAVA_OPTS} -Duser=${USER} -Dhostname=${HOSTNAME} -Dlogdir="${logdir}" -cp > "${cp}" org.apache.ranger.authentication.UnixAuthenticationService > -enableUnixAuth > ${logdir}/auth.log 2>&1 &' in ranger-usersync-services.sh > > Change > '-Dlog4j.configuration=file:/etc/ranger/usersync/conf/log4j.properties' to > '-Dlog4j.configuration=file:${RANGER_BASE_DIR}/usersync/conf/log4j.properties' > for dynamic configuration. > > > Diffs > ----- > > unixauthservice/scripts/ranger-usersync-services.sh 97f5708 > > > Diff: https://reviews.apache.org/r/59571/diff/1/ > > > Testing > ------- > > test done? > > > Thanks, > > Qiang Zhang > >
