-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59729/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-1628
https://issues.apache.org/jira/browse/RANGER-1628
Repository: ranger
Description
-------
When sorting collection of objects, it is better to provide a specific
Comparator to Collections.sort() API than to have the class of the object
implement Comparable interface. It gives more flexibility of sorting and does
not require more stringent requirements such as implementing hashCode() and
equals() APIs for the object's class.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerServiceResourceMatcher.java
23dfe23
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEvaluatorForTag.java
46f8cb0
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
fc34da0
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java
80d0fd4
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java
103c057
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
1340007
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
38072e1
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyItemEvaluator.java
2458e9d
agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceEvaluator.java
eed58e1
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java
a53c8dc
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java
0a66994
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/ResourceMatcher.java
853c525
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java
7897f46
Diff: https://reviews.apache.org/r/59729/diff/1/
Testing
-------
Compiled clean and ran all unit tests successfully
Thanks,
Abhay Kulkarni
